]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
Revert "screencastService: Use 'screen' encoder profile for openH264"
authorRobert Mader <robert.mader@collabora.com>
Mon, 15 Apr 2024 18:13:40 +0000 (20:13 +0200)
committerRobert Mader <robert.mader@collabora.com>
Mon, 15 Apr 2024 18:23:42 +0000 (20:23 +0200)
Unfortunately it turned out that this change does increase frame skips
in the recorded files on several tested devices, greatly outweighing
any small visual benefit it might have.

This reverts commit 490ecc536ab6b2f9320592930be5aae473297934.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3268>

js/dbusServices/screencast/screencastService.js

index c96a05dd3acb74841a9d676d4f4f94c02353efe7..d664a51b08316b47c1f6e4d61dd3d9b6147e8fb7 100644 (file)
@@ -38,7 +38,7 @@ const PIPELINES = [
             'capsfilter caps=video/x-raw(memory:DMABuf),max-framerate=%F/1 ! \
              glupload ! glcolorconvert ! gldownload ! \
              queue ! \
-             openh264enc deblocking=off background-detection=false complexity=low adaptive-quantization=false qp-max=26 qp-min=26 multi-thread=%T slice-mode=auto usage-type=screen ! \
+             openh264enc deblocking=off background-detection=false complexity=low adaptive-quantization=false qp-max=26 qp-min=26 multi-thread=%T slice-mode=auto ! \
              queue ! \
              h264parse ! \
              mp4mux fragment-duration=500 fragment-mode=first-moov-then-finalise',
@@ -50,7 +50,7 @@ const PIPELINES = [
             'capsfilter caps=video/x-raw,max-framerate=%F/1 ! \
              videoconvert chroma-mode=none dither=none matrix-mode=output-only n-threads=%T ! \
              queue ! \
-             openh264enc deblocking=off background-detection=false complexity=low adaptive-quantization=false qp-max=26 qp-min=26 multi-thread=%T slice-mode=auto usage-type=screen ! \
+             openh264enc deblocking=off background-detection=false complexity=low adaptive-quantization=false qp-max=26 qp-min=26 multi-thread=%T slice-mode=auto ! \
              queue ! \
              h264parse ! \
              mp4mux fragment-duration=500 fragment-mode=first-moov-then-finalise',